Add reusable GitHub Action to install and cache nats server #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
force-pushed
the
use-server-binaries-from-nats-dev
branch
6 times, most recently
from
c49a18e to
430e3fd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a reusable GitHub Action to optimize NATS server installation in CI workflows, reducing installation time from 2-3 minutes to 2-3 seconds through caching.
- Replaces manual installation scripts with a centralized GitHub Action
- Implements caching strategy for NATS server binaries across workflow runs
- Simplifies workflow configuration by eliminating manual PATH management
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/actions/setup-nats-server/action.yml |
New composite action that downloads, caches, and configures NATS server |
.github/workflows/test.yml |
Updated to use the new action and simplified matrix configuration |
nats/scripts/install_nats.sh |
Removed obsolete installation script |
nats/tests/utils.py |
Updated comment to reference official NATS installation docs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
caspervonb
force-pushed
the
use-server-binaries-from-nats-dev
branch
7 times, most recently
from
6f2ee8a to
a467549
Compare
Signed-off-by: Casper Beyer <[email protected]>
caspervonb
force-pushed
the
use-server-binaries-from-nats-dev
branch
2 times, most recently
from
21e6cd5 to
3e13e9a
Compare
|
Windows being stubborn, going a different route. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings install time of nats-server from 2-3 minutes to 2-3 seconds.